Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for ZFS #1349

Closed
wants to merge 57 commits into from
Closed

Add check for ZFS #1349

wants to merge 57 commits into from

Conversation

mboylevt
Copy link

@mboylevt mboylevt commented Feb 5, 2015

I've added some basic checks for the zfs filesystem. These checks give insights into space used/available, compression/deduplication ratio, and basic health checks.

mboylevt and others added 30 commits January 27, 2015 09:51
@mboylevt
initial commit of zfs.py
2991d4e
@mboylevt
Add check bits, gauge calls
d6d433e
@mboylevt
initial blank conf
a10eaed
@mboylevt
Remove main entrypoint for check, correct yaml format
9f0a688
@mboylevt
Add proper subprocess handling to zfs
e9d7915
@mboylevt
Add debug info
d5a1a79
@mboylevt
check for bad data
a28ddbd
@mboylevt
Add service check
f77c793
Fix spacing
0c3b6e8
@mboylevt
Refactor zfs reporting to make it more flexible
37117ab
@mboylevt
Change name to zfs_name to avoid confusion
aa9f446
@mboylevt
Added retrieval for zpool checks and metrics
bd47f47
@mboylevt
Add zpool processing
eab5a7c
@mboylevt
int -> float. duh
d8e22ea
@mboylevt
String casting
ef9c8d2
@mboylevt
Final changes
471b068
@mboylevt
Dependency injection for subprocess so that Unittests can mock it
b1d562c
@mboylevt
Add unittests for convert_human_to_bytes, update function to address …
b7c0a77 
…found bugs :)
@mboylevt
Add more unit tests
a5efc3d
@mboylevt
Whitespace for triggering travis
748f610
@mboylevt
Add unit test for process_zfs_usage, update function itself to return…
ff0d53b 
… consistent strings.
Added _process_zpool tests
e40220a
@mboylevt
Remove unecessary comment -- issue addressed
2e1acad
@mboylevt
update comment
b0f23a5
@mboylevt
initial commit of zfs.py
24a3f38
@mboylevt
Add check bits, gauge calls
e56e43a
@mboylevt
initial blank conf
39a4f3a
@mboylevt
Remove main entrypoint for check, correct yaml format
797bcb9
@mboylevt
Add proper subprocess handling to zfs
74ab77e
@mboylevt
Add debug info
0e5464f
@remh
Copy link
Contributor

remh commented Feb 5, 2015

Thanks a lot @mboylevt ! This looks like an awesome pull request!

We are currently in the process of releasing our 5.2.0 agent, hence our master branch is frozen for now.

We will review your Pull request when we will be preparing our 5.3.0 release.
Thanks again!

@remh remh added this to the 5.3.0 milestone Feb 5, 2015
@remh
Copy link
Contributor

remh commented Feb 5, 2015

Also one first nitpick, could you squash these commits into a single one please ?
Thanks again!

remh
remh reviewed Mar 1, 2015
View reviewed changes
checks.d/zfs.py
@@ -0,0 +1,232 @@
#!/usr/bin/python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@mboylevt
Copy link
Author

mboylevt commented Mar 3, 2015

@remh at this point, I'm not sure how to squash my original commits w/o squashing the merged in commits from your master as well. Would you prefer that I simply re-open this pull request?

@remh remh modified the milestones: To be determined, 5.3.0 Mar 16, 2015
@degemer degemer mentioned this pull request Apr 23, 2015
Merged
@mboylevt
Copy link
Author

Any update on getting this merged?

@remh
Copy link
Contributor

remh commented May 18, 2015

Hi @mboylevt sorry for the long delay.
Unfortunately we won't merge this PR.

The mains are that:

  • We are trying to avoid the use of subprocess more and more in the agent
  • This pull requests requires root access to work and there is currently no nice way for a user to run the agent as root (and we don't want to recommend doing it).

In the same time, you can definitely use it as a custom check without having this merged, so it shouldn't block you.

Thanks a lot for your time and let us know if you have more questions.

@remh remh closed this May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1 - Ready checks new integration
Projects
None yet
Milestone
To be determined
Development

Successfully merging this pull request may close these issues.
2 participants
@mboylevt @remh